Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement uwb simulator driver dispatch handling for the LRP DDI #58

Merged
merged 19 commits into from
Feb 1, 2023
Merged

Implement uwb simulator driver dispatch handling for the LRP DDI #58

merged 19 commits into from
Feb 1, 2023

Conversation

abeltrano
Copy link
Contributor

Type

  • Bug fix
  • Feature addition
  • Feature update
  • Breaking change
  • Non-functional change
  • Documentation
  • Infrastructure

Goals

Allow IOCTLs to be properly dispatched to callbacks for the LRP DDI.

Technical Details

  • Move DDI conversions functions to the adaption library.
  • Implement dispatching to callbacks.
  • Change plog to be version-less. This is to address a bug where the driver project is stuck on obtaining v1.1.8 even though v1.1.9 works fine (locally in CMake projects, and in Windows). This issue is being tracked with Bug: Fix plog to use explicit version #57.
  • Rename UwbCx LRP DDI "glue" header into something more reflective of its purpose.
  • Complete driver requests when there is a failure to obtain the i/o buffers.

Test Results

  • Ad-hoc testing with the driver so far, more TBD.

Reviewer Focus

None

Future Work

Checklist

  • Build target all compiles cleanly.
  • clang-format and clang-tidy deltas produced no new output.
  • Newly added functions include doxygen-style comment block.

@abeltrano
Complete the request with appropriate status upon failing to retrieve…
b230be2 
… input or output buffers.
@abeltrano
Implement top-level request handler and DeviceReset() callback.
b25aa02
@abeltrano
Formatting.
9f055fb
@abeltrano
Update session state to enumeration.
05b765b
@abeltrano
Implement GetSessionState() callback.
2f249ee
@abeltrano
Remove version.
30d2cdd
@abeltrano
Complete impl of OnUwbGetSessionState().
a549cc1
@abeltrano
Use default version selection for plog.
9a4b273
@abeltrano
Use referece type instead of pointer type.
74c1652
@abeltrano
Implement a few getter handlers.
d231b14
@abeltrano
Implement from(UwbStatus) correctly.
d962eae
@abeltrano
Move DDI adaption functions to uwbcxadaption lib.
197bccf
@abeltrano
Rename.
7eea3c5
@abeltrano
Update public header file name.
a812ce4
@abeltrano
Rename uwbcx glue file to something better.
7bd54fb
@abeltrano
Streamline uwbcx driver interface.
2410361
@abeltrano
Update fira names.
086b5e7
@abeltrano
Move to library cx adaption functions.
ef63a7d
@abeltrano abeltrano requested a review from a team as a code owner January 31, 2023 21:52
@abeltrano abeltrano merged commit 32d7df1 into develop Feb 1, 2023
@abeltrano abeltrano deleted the setappcfgimpl2 branch February 1, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forwardpointer forwardpointer forwardpointer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abeltrano @forwardpointer